diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2021-08-20 18:11:13 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-20 18:11:13 +0200 |
| commit | 8fdffbf3a17ebfc8e7043264cce516d23e9f5345 (patch) | |
| tree | a6ba2b4db0813272b8f54deb65e4fa15490245a6 /src/lib/protocols/smpp.c | |
| parent | 55eec29c08fa2cf66f5f3ef8868ce4e0de52111f (diff) | |
Compile everything with "-W -Wall -Wno-unused-parameter" flags (#1276)
Fix all the warnings.
Getting rid of "-Wno-unused-parameter" is quite complex because some
parameters usage depends on compilation variable (i.e.
`--enable-debug-messages`).
The "-Werror" flag has been added only in Travis builds to avoid
breaking the builds to users using uncommon/untested
OS/compiler/enviroment.
Tested on:
* x86_64; Ubuntu 20.04; gcc 7,8,9,10,11; clang 7,8,9,10,11,12
* x86_64; CentOS 7.7; gcc 4.8.5 (with "--disable-gcrypt" flag)
* Raspberry 4; Debian 10.10; gcc 8.3.0
Diffstat (limited to 'src/lib/protocols/smpp.c')
| -rw-r--r-- | src/lib/protocols/smpp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/protocols/smpp.c b/src/lib/protocols/smpp.c index 318ff3cea..6d9031756 100644 --- a/src/lib/protocols/smpp.c +++ b/src/lib/protocols/smpp.c @@ -68,7 +68,7 @@ void ndpi_search_smpp_tcp(struct ndpi_detection_module_struct* ndpi_struct, u_int32_t tmp_pdu_l = 0; u_int16_t pdu_c = 1; // loop PDUs (check if lengths are valid) - while(total_pdu_l < (packet->payload_packet_len-4)) { + while(total_pdu_l < ((uint32_t)packet->payload_packet_len-4)) { // get next PDU length tmp_pdu_l = ntohl(get_u_int32_t(packet->payload, total_pdu_l)); // if zero or overflowing , return, will try the next TCP segment |