aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols/skype.c
diff options
context:
space:
mode:
authorRavi Kerur <ravi.kerur@viasat.com>2019-09-16 13:56:17 -0700
committerRavi Kerur <ravi.kerur@viasat.com>2019-09-16 13:56:17 -0700
commitce79626679f5ac1a173bccbf4385791cfba956e3 (patch)
treea97437edda25963d9e96afff77d5cc8f1a7f421a /src/lib/protocols/skype.c
parent23780a655d8e16842f3a16946e2a12defde83f2c (diff)
parent8f4e8d8254d79404e9b9490f9ab9bb5296194d68 (diff)
Merge branch 'dev' of https://github.com/ntop/nDPI into ndpi_icmp
Diffstat (limited to 'src/lib/protocols/skype.c')
-rw-r--r--src/lib/protocols/skype.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/lib/protocols/skype.c b/src/lib/protocols/skype.c
index b36e03277..45a86f05f 100644
--- a/src/lib/protocols/skype.c
+++ b/src/lib/protocols/skype.c
@@ -83,7 +83,8 @@ static void ndpi_check_skype(struct ndpi_detection_module_struct *ndpi_struct, s
&& flow->l4.tcp.seen_syn
&& flow->l4.tcp.seen_syn_ack
&& flow->l4.tcp.seen_ack) {
-
+ /* Disabled this logic as it's too weak and leads to false positives */
+#if 0
if((payload_len == 8) || (payload_len == 3) || (payload_len == 17)) {
// printf("[SKYPE] payload_len=%u\n", payload_len);
/* printf("[SKYPE] %u/%u\n", ntohs(packet->tcp->source), ntohs(packet->tcp->dest)); */
@@ -95,6 +96,7 @@ static void ndpi_check_skype(struct ndpi_detection_module_struct *ndpi_struct, s
}
/* printf("[SKYPE] [id: %u][len: %d]\n", flow->l4.tcp.skype_packet_id, payload_len); */
+#endif
} else {
NDPI_EXCLUDE_PROTO(ndpi_struct, flow);
}