diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2021-08-20 18:11:13 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-20 18:11:13 +0200 |
| commit | 8fdffbf3a17ebfc8e7043264cce516d23e9f5345 (patch) | |
| tree | a6ba2b4db0813272b8f54deb65e4fa15490245a6 /src/lib/protocols/skype.c | |
| parent | 55eec29c08fa2cf66f5f3ef8868ce4e0de52111f (diff) | |
Compile everything with "-W -Wall -Wno-unused-parameter" flags (#1276)
Fix all the warnings.
Getting rid of "-Wno-unused-parameter" is quite complex because some
parameters usage depends on compilation variable (i.e.
`--enable-debug-messages`).
The "-Werror" flag has been added only in Travis builds to avoid
breaking the builds to users using uncommon/untested
OS/compiler/enviroment.
Tested on:
* x86_64; Ubuntu 20.04; gcc 7,8,9,10,11; clang 7,8,9,10,11,12
* x86_64; CentOS 7.7; gcc 4.8.5 (with "--disable-gcrypt" flag)
* Raspberry 4; Debian 10.10; gcc 8.3.0
Diffstat (limited to 'src/lib/protocols/skype.c')
| -rw-r--r-- | src/lib/protocols/skype.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/protocols/skype.c b/src/lib/protocols/skype.c index 9e17f32a1..de2d1f092 100644 --- a/src/lib/protocols/skype.c +++ b/src/lib/protocols/skype.c @@ -30,7 +30,7 @@ static int is_port(u_int16_t a, u_int16_t b, u_int16_t c) { static int ndpi_check_skype_udp_again(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) { struct ndpi_packet_struct *packet = &flow->packet; u_int32_t payload_len = packet->payload_packet_len; - + int i; const uint8_t id_flags_iv_crc_len = 11; const uint8_t crc_len = sizeof(flow->l4.udp.skype_crc); const uint8_t crc_offset = id_flags_iv_crc_len - crc_len; @@ -48,7 +48,7 @@ static int ndpi_check_skype_udp_again(struct ndpi_detection_module_struct *ndpi_ u_int8_t detected = 1; /* Check if both packets have the same CRC */ - for (int i = 0; i < crc_len && detected; i++) { + for (i = 0; i < crc_len && detected; i++) { if (packet->payload[crc_offset + i] != flow->l4.udp.skype_crc[i]) detected = 0; } |