diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2023-05-28 12:59:18 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-28 12:59:18 +0200 |
| commit | 7ce14da0c8c06967013503187081fa3a146ab8bb (patch) | |
| tree | 0bd13c3aa54abf10d3901ef2f9f8d1435b912d88 /src/lib/protocols/radius.c | |
| parent | 6da3474203fc2ff5981f6c73f7ad02fa81138166 (diff) | |
Remove some useless checks (#1993)
In the main dissector callbacks the flow protocols are (almost) always
unknown. Only two exceptions:
* extra dissection data path
* HTTP sub-protocols
Diffstat (limited to 'src/lib/protocols/radius.c')
| -rw-r--r-- | src/lib/protocols/radius.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/lib/protocols/radius.c b/src/lib/protocols/radius.c index 77e84e731..0c48bb19c 100644 --- a/src/lib/protocols/radius.c +++ b/src/lib/protocols/radius.c @@ -41,8 +41,7 @@ static void ndpi_check_radius(struct ndpi_detection_module_struct *ndpi_struct, // const u_int8_t *packet_payload = packet->payload; u_int32_t payload_len = packet->payload_packet_len; - if(packet->udp != NULL && - (packet->udp->dest == htons(RADIUS_PORT) || packet->udp->source == htons(RADIUS_PORT) || + if((packet->udp->dest == htons(RADIUS_PORT) || packet->udp->source == htons(RADIUS_PORT) || packet->udp->dest == htons(RADIUS_PORT_ACC) || packet->udp->source == htons(RADIUS_PORT_ACC) || packet->udp->dest == htons(RADIUS_PORT_ACC_ALTERNATIVE) || packet->udp->source == htons(RADIUS_PORT_ACC_ALTERNATIVE))) { struct radius_header *h = (struct radius_header*)packet->payload; @@ -69,9 +68,7 @@ static void ndpi_search_radius(struct ndpi_detection_module_struct *ndpi_struct, { NDPI_LOG_DBG(ndpi_struct, "search radius\n"); - /* skip marked packets */ - if(flow->detected_protocol_stack[0] != NDPI_PROTOCOL_RADIUS) - ndpi_check_radius(ndpi_struct, flow); + ndpi_check_radius(ndpi_struct, flow); } |