diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2021-08-20 18:11:13 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-20 18:11:13 +0200 |
| commit | 8fdffbf3a17ebfc8e7043264cce516d23e9f5345 (patch) | |
| tree | a6ba2b4db0813272b8f54deb65e4fa15490245a6 /src/lib/protocols/mail_smtp.c | |
| parent | 55eec29c08fa2cf66f5f3ef8868ce4e0de52111f (diff) | |
Compile everything with "-W -Wall -Wno-unused-parameter" flags (#1276)
Fix all the warnings.
Getting rid of "-Wno-unused-parameter" is quite complex because some
parameters usage depends on compilation variable (i.e.
`--enable-debug-messages`).
The "-Werror" flag has been added only in Travis builds to avoid
breaking the builds to users using uncommon/untested
OS/compiler/enviroment.
Tested on:
* x86_64; Ubuntu 20.04; gcc 7,8,9,10,11; clang 7,8,9,10,11,12
* x86_64; CentOS 7.7; gcc 4.8.5 (with "--disable-gcrypt" flag)
* Raspberry 4; Debian 10.10; gcc 8.3.0
Diffstat (limited to 'src/lib/protocols/mail_smtp.c')
| -rw-r--r-- | src/lib/protocols/mail_smtp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/lib/protocols/mail_smtp.c b/src/lib/protocols/mail_smtp.c index 91f9a00a2..66e4cc0f0 100644 --- a/src/lib/protocols/mail_smtp.c +++ b/src/lib/protocols/mail_smtp.c @@ -88,7 +88,8 @@ void ndpi_search_mail_smtp_tcp(struct ndpi_detection_module_struct *ndpi_struct, if(flow->host_server_name[0] == '\0') { if(packet->line[a].len > 4) { - int i, len; + int i; + unsigned int len; if(packet->line[a].ptr[4] != '(') { for(i=5; (i<packet->line[a].len-1) && (packet->line[a].ptr[i] != ' '); i++) |