diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2022-07-29 12:07:14 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-29 12:07:14 +0200 |
| commit | 95e16872fadfc98256fdcf729f267237c727e4c3 (patch) | |
| tree | 226da4705b52e2b8acdb43f802aab62fb07507f1 /src/lib/protocols/mail_smtp.c | |
| parent | 172e698bb8239d0060d9d494adfba928507f95b2 (diff) | |
First step in simplify `ndpi_process_extra_packet()` (#1680)
Move the prottocol specific logic into the proper dissector code, where
it belongs.
Next step: remove that list of protocols. Long goal: remove this
function altogether...
Diffstat (limited to 'src/lib/protocols/mail_smtp.c')
| -rw-r--r-- | src/lib/protocols/mail_smtp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/lib/protocols/mail_smtp.c b/src/lib/protocols/mail_smtp.c index a2035bfe6..1bb6068a4 100644 --- a/src/lib/protocols/mail_smtp.c +++ b/src/lib/protocols/mail_smtp.c @@ -440,7 +440,9 @@ int ndpi_extra_search_mail_smtp_tcp(struct ndpi_detection_module_struct *ndpi_st } } else { ndpi_search_mail_smtp_tcp(ndpi_struct, flow); - rc = (flow->l4.tcp.ftp_imap_pop_smtp.password[0] == '\0') ? 1 : 0; + rc = ((flow->l4.tcp.ftp_imap_pop_smtp.password[0] == '\0') && + (flow->l4.tcp.ftp_imap_pop_smtp.auth_tls == 1 || + flow->l4.tcp.ftp_imap_pop_smtp.auth_done == 0)) ? 1 : 0; } #ifdef SMTP_DEBUG |