diff options
| author | theirix <theirix@gmail.com> | 2016-04-12 22:14:13 +0300 |
|---|---|---|
| committer | theirix <theirix@gmail.com> | 2016-04-12 22:14:13 +0300 |
| commit | c22d3d3cae8fc6d5fcf1b7320a7602426a9b9ca2 (patch) | |
| tree | adebbf469efc03bba8a8d955b5116b35ae50ef3e /src/lib/protocols/h323.c | |
| parent | fb3fc0c6de201a2ab34b6f7ce4d5dfc2c54c3b5e (diff) | |
Fixed more buffer overflows with small packets
Diffstat (limited to 'src/lib/protocols/h323.c')
| -rw-r--r-- | src/lib/protocols/h323.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/lib/protocols/h323.c b/src/lib/protocols/h323.c index 1d503a747..7a94dabd5 100644 --- a/src/lib/protocols/h323.c +++ b/src/lib/protocols/h323.c @@ -27,7 +27,8 @@ void ndpi_search_h323(struct ndpi_detection_module_struct *ndpi_struct, struct n NDPI_LOG(NDPI_PROTOCOL_H323, ndpi_struct, NDPI_LOG_DEBUG, "calculated dport over tcp.\n"); /* H323 */ - if((packet->payload[0] == 0x03) + if(packet->payload_packet_len >= 3 + && (packet->payload[0] == 0x03) && (packet->payload[1] == 0x00) && (packet->payload[2] == 0x00)) { struct tpkt *t = (struct tpkt*)packet->payload; @@ -63,7 +64,8 @@ void ndpi_search_h323(struct ndpi_detection_module_struct *ndpi_struct, struct n sport = ntohs(packet->udp->source), dport = ntohs(packet->udp->dest); NDPI_LOG(NDPI_PROTOCOL_H323, ndpi_struct, NDPI_LOG_DEBUG, "calculated dport over udp.\n"); - if(packet->payload[0] == 0x80 && packet->payload[1] == 0x08 && (packet->payload[2] == 0xe7 || packet->payload[2] == 0x26) && + if(packet->payload_packet_len >= 5 && packet->payload[0] == 0x80 && packet->payload[1] == 0x08 && + (packet->payload[2] == 0xe7 || packet->payload[2] == 0x26) && packet->payload[4] == 0x00 && packet->payload[5] == 0x00) { NDPI_LOG(NDPI_PROTOCOL_H323, ndpi_struct, NDPI_LOG_DEBUG, "found H323 broadcast.\n"); |