diff options
| author | emanuele-f <black.silver@hotmail.it> | 2019-10-03 15:52:55 +0200 |
|---|---|---|
| committer | emanuele-f <black.silver@hotmail.it> | 2019-10-03 15:52:55 +0200 |
| commit | 04a97fa72b38e647f05f84177c1398bcd4e45614 (patch) | |
| tree | 9a352819b97b2c680b95d133c18c589cd9de0235 /src/lib/protocols/dns.c | |
| parent | c247a9d1919d84ba6f781e656e837baaa9cfc386 (diff) | |
Fix DNS reply dissection issues
Diffstat (limited to 'src/lib/protocols/dns.c')
| -rw-r--r-- | src/lib/protocols/dns.c | 19 |
1 files changed, 18 insertions, 1 deletions
diff --git a/src/lib/protocols/dns.c b/src/lib/protocols/dns.c index 86575f23e..7c3ead514 100644 --- a/src/lib/protocols/dns.c +++ b/src/lib/protocols/dns.c @@ -195,6 +195,16 @@ static int search_valid_dns(struct ndpi_detection_module_struct *ndpi_struct, /* *********************************************** */ +static int search_dns_again(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) { + /* possibly dissect the DNS reply */ + ndpi_search_dns(ndpi_struct, flow); + + /* stop extra processing */ + return(0); +} + +/* *********************************************** */ + void ndpi_search_dns(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) { int payload_offset; u_int8_t is_query; @@ -271,9 +281,16 @@ void ndpi_search_dns(struct ndpi_detection_module_struct *ndpi_struct, struct nd ret.master_protocol = NDPI_PROTOCOL_DNS; } - if(is_query && (ndpi_struct->dns_dont_dissect_response == 0)) { + if(is_query && (ndpi_struct->dns_dont_dissect_response == 0) && (flow->num_processed_pkts == 1)) { /* In this case we say that the protocol has been detected just to let apps carry on with their activities */ ndpi_set_detected_protocol(ndpi_struct, flow, ret.app_protocol, ret.master_protocol); + + /* This is necessary to inform the core to call this dissector again */ + flow->check_extra_packets = 1; + + /* Dissect at most 1 more packets, hopefully the DNS response */ + flow->max_extra_packets_to_check = 1; + flow->extra_packets_func = search_dns_again; return; /* The response will set the verdict */ } |