diff options
author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2022-08-05 14:14:38 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-08-05 14:14:38 +0200 |
commit | c0732eda45884de91e0c221e9dd23eeec364bf68 (patch) | |
tree | 50a3146ccb9463fb4724fcf8268122d9bdccd371 /src/lib/protocols/bittorrent.c | |
parent | 346e274a1b1d713aedfc341f7d1300009f9f0e1a (diff) |
HTTP: improve sub-classification (#1696)
Content-matched sub-protocols (DASH, IPP, MPEGDASH...) shouldn't
ovewrite the previous master protocol (if any; usually HTTP).
Furthermore. the HTTP dissector shouldn't update the classification
(in the extra-dissection code path) if a content-matched sub-protocols
has already been found.
This commit should address the first part of the changes described in #1687.
Diffstat (limited to 'src/lib/protocols/bittorrent.c')
-rw-r--r-- | src/lib/protocols/bittorrent.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/lib/protocols/bittorrent.c b/src/lib/protocols/bittorrent.c index 505f2ad16..b5ea1d1e6 100644 --- a/src/lib/protocols/bittorrent.c +++ b/src/lib/protocols/bittorrent.c @@ -109,7 +109,8 @@ static void ndpi_add_connection_as_bittorrent(struct ndpi_detection_module_struc if(check_hash) ndpi_search_bittorrent_hash(ndpi_struct, flow, bt_offset); - ndpi_set_detected_protocol(ndpi_struct, flow, NDPI_PROTOCOL_BITTORRENT, NDPI_PROTOCOL_UNKNOWN, confidence); + ndpi_set_detected_protocol_keeping_master(ndpi_struct, flow, NDPI_PROTOCOL_BITTORRENT, + confidence); if(flow->protos.bittorrent.hash[0] == '\0') { /* This is necessary to inform the core to call this dissector again */ |