diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2021-08-20 18:11:13 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-20 18:11:13 +0200 |
| commit | 8fdffbf3a17ebfc8e7043264cce516d23e9f5345 (patch) | |
| tree | a6ba2b4db0813272b8f54deb65e4fa15490245a6 /src/lib/ndpi_utils.c | |
| parent | 55eec29c08fa2cf66f5f3ef8868ce4e0de52111f (diff) | |
Compile everything with "-W -Wall -Wno-unused-parameter" flags (#1276)
Fix all the warnings.
Getting rid of "-Wno-unused-parameter" is quite complex because some
parameters usage depends on compilation variable (i.e.
`--enable-debug-messages`).
The "-Werror" flag has been added only in Travis builds to avoid
breaking the builds to users using uncommon/untested
OS/compiler/enviroment.
Tested on:
* x86_64; Ubuntu 20.04; gcc 7,8,9,10,11; clang 7,8,9,10,11,12
* x86_64; CentOS 7.7; gcc 4.8.5 (with "--disable-gcrypt" flag)
* Raspberry 4; Debian 10.10; gcc 8.3.0
Diffstat (limited to 'src/lib/ndpi_utils.c')
| -rw-r--r-- | src/lib/ndpi_utils.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/lib/ndpi_utils.c b/src/lib/ndpi_utils.c index 250a010ed..a7ba2818e 100644 --- a/src/lib/ndpi_utils.c +++ b/src/lib/ndpi_utils.c @@ -1048,7 +1048,7 @@ u_char* ndpi_base64_decode(const u_char *src, size_t len, size_t *out_len) { char* ndpi_base64_encode(unsigned char const* bytes_to_encode, size_t in_len) { size_t len = 0, ret_size; char *ret; - int i = 0; + int j, i = 0; unsigned char char_array_3[3]; unsigned char char_array_4[4]; @@ -1072,7 +1072,7 @@ char* ndpi_base64_encode(unsigned char const* bytes_to_encode, size_t in_len) { } if(i) { - for(int j = i; j < 3; j++) + for(j = i; j < 3; j++) char_array_3[j] = '\0'; char_array_4[0] = (char_array_3[0] & 0xfc) >> 2; @@ -1080,7 +1080,7 @@ char* ndpi_base64_encode(unsigned char const* bytes_to_encode, size_t in_len) { char_array_4[2] = ((char_array_3[1] & 0x0f) << 2) + ((char_array_3[2] & 0xc0) >> 6); char_array_4[3] = char_array_3[2] & 0x3f; - for(int j = 0; (j < i + 1); j++) + for(j = 0; (j < i + 1); j++) ret[len++] = base64_table[char_array_4[j]]; while((i++ < 3)) |