diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2022-07-25 12:57:33 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-25 12:57:33 +0200 |
| commit | b190dab6bc23bcacf127f1f8d93df257f40bb898 (patch) | |
| tree | 7fb68c7a554501f6e8d9a33fedb3ed35d6a8e5bd /src/lib/ndpi_main.c | |
| parent | 86a3e4c8c331773156283d365aa6a9b103ca44ff (diff) | |
Improve handling of HTTP-Proxy and HTTP-Connect (#1673)
Treat HTTP-Proxy and HTTP-Connect flows like the HTTP ones:
print/serialize all the attributes and allow parsing of replies.
The line about "1kxun" has been removed to avoid regressions in 1KXUN
classification in `tests/pcap/1kxun.pcap`. I haven't fully understod
what was happening but the comment at the beginning of `static
ndpi_category_match category_match[]` says that we can't have overlaps
between `host_match` and `category_match` lists and that is no longer true
since 938e89ca.
Bottom line: removing this line seems the right thing to do, anyway.
Diffstat (limited to 'src/lib/ndpi_main.c')
| -rw-r--r-- | src/lib/ndpi_main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/lib/ndpi_main.c b/src/lib/ndpi_main.c index 0ef07454e..53f2dad3a 100644 --- a/src/lib/ndpi_main.c +++ b/src/lib/ndpi_main.c @@ -8114,6 +8114,8 @@ u_int8_t ndpi_extra_dissection_possible(struct ndpi_detection_module_struct *ndp break; case NDPI_PROTOCOL_HTTP: + case NDPI_PROTOCOL_HTTP_PROXY: + case NDPI_PROTOCOL_HTTP_CONNECT: if((flow->host_server_name[0] == '\0') || (flow->http.response_status_code == 0)) return(1); break; |