diff options
| author | Nardi Ivan <nardi.ivan@gmail.com> | 2022-09-14 10:44:16 +0200 |
|---|---|---|
| committer | Toni <matzeton@googlemail.com> | 2022-09-14 17:52:01 +0200 |
| commit | 9ce4d40d1490fb0f89d9d5eb6d249529cbd60513 (patch) | |
| tree | 60c75381e87229f696b306f64266206b342c6213 /src/lib/ndpi_bitmap.c | |
| parent | 7571f48392ef3b79eb25b94f1da6932a137c4f02 (diff) | |
Remove a case of guessed sub-classification
This code is triggered only for "unknown" flows with a valid
sni/hostname.
Why in that case the guessed classification should be
something like `DNS/Subprotocol_depending_on_hostname`? Why DNS as
master and not HTTP or TLS or QUIC?
Furthermore, I have not been able to trigger a positive match from that
lookup. I strongly think that if we had a valid subprotocol, we would
have a valid master in the first place.
In doubt, remove it completely.
As a follow up, we should investigate why some dissectors (the HTTP one,
at least) set the sni/hostname field without setting a valid protocol,
in the first place.
This behaviour seems quite suspicious, if not plainly buggy.
Diffstat (limited to 'src/lib/ndpi_bitmap.c')
0 files changed, 0 insertions, 0 deletions