diff options
author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2023-05-17 11:26:25 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-17 11:26:25 +0200 |
commit | b1bcf1ff6018c55f8daaa107070e1c8503082b2b (patch) | |
tree | bb1416b3e58237e7ecae8b27102e202328919491 /example/reader_util.c | |
parent | ace32c9dfefb2ea3130cfcdf086aacf22532c70c (diff) |
Fix classification-by-ip in `ndpi_detection_giveup` (#1981)
Return the "classification-by-ip" as protocol results only if no other
results are available.
In particular, never return something like
"protocol_by_port/protocol_by_ip" (i.e. `NTP/Apple`,
BitTorrent/GoogleCloud`, `Zoom/AWS`) because this kind of classification
is quite confusing, if not plainly wrong.
Notes:
* the information about "classification-by-ip" is always available, so
no information is lost with this change;
* in the unit tests, the previous classifications with confidence
`NDPI_CONFIDENCE_DPI_PARTIAL` were wrong, as noted in #1957
Diffstat (limited to 'example/reader_util.c')
0 files changed, 0 insertions, 0 deletions