diff options
author | Stuart Reilly <themadprofessor@users.noreply.github.com> | 2019-07-23 10:47:25 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-07-23 10:47:25 +0100 |
commit | e781ddfa43ce9963c705c93fd015d4df3f39d08c (patch) | |
tree | a14d3d7a688fad00ec51603b47ff52ec4315f234 /CONTRIBUTING.md | |
parent | 974abaa275079beababe4a8f381154d04adc91b6 (diff) |
Create CONTRIBUTING.md
Add simple contribution guidelines.
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r-- | CONTRIBUTING.md | 27 |
1 files changed, 27 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000000000..8626d168c --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,27 @@ +# How to contribute + +Please keep all code, comments, issues and pull requests in English, otherwise they will be **removed**. + +## Found a bug? + +- First, check there are no already open issues for the bug. See [here](https://github.com/ntop/nDPI/issues). +- If there is not open issue addressing the bug, [open a new one](https://github.com/ntop/nDPI/issues/new). +- Make sure to include a **descriptive and clear title and description**, including the **version of nDPI** being used. +- Try to include steps to reproduce the bug. +- If applicable, try to provide a stacktrace. +- Providing a simple test case which shows the bug would help resolve the issue faster. + +## Written a new protocol dissector? + +- Ensure you have followed the guide in the [README](https://github.com/ntop/nDPI#how-to-add-a-new-protocol-dissector). +- Open a new pull request with a **clear, descriptive** title. +- Ensure the pull request passes CI testing. Any pull request which fails CI will be **ignored**. +- If possible, add a new test for the new protocol. See [existing tests](https://github.com/ntop/nDPI/tree/dev/tests) for examples. + +## Written a fix for a bug? + +- Open a new pull request with a **clear, descriptive** title. +- If there is an open issue for the bug, ensure the description of the pull request contains `Fixes #issue_number`. +- Ensure the pull request passes CI testing. Any pull request which fails CI will be **ignored**. + +Finally, thank you for your contributions. |