aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Nardi <12729895+IvanNardi@users.noreply.github.com>2024-04-13 18:43:41 +0200
committerGitHub <noreply@github.com>2024-04-13 18:43:41 +0200
commitd97afd6efd0a6946dd546dacdd4cb3e753d74298 (patch)
treebcb47b48fd20f076ca8e61d09084345d609e14cd
parent06f48140859f197e2730b573eb1bd6fad1a8f74a (diff)
STUN: fix attributes list iteration (#2391)
We need to check all the attributes, to look for any possible metadata
-rw-r--r--src/lib/protocols/stun.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/lib/protocols/stun.c b/src/lib/protocols/stun.c
index 3feb2d17b..75818e325 100644
--- a/src/lib/protocols/stun.c
+++ b/src/lib/protocols/stun.c
@@ -505,20 +505,15 @@ int is_stun(struct ndpi_detection_module_struct *ndpi_struct,
if(valid) {
if(strstr(flow->host_server_name, "google.com") != NULL) {
*app_proto = NDPI_PROTOCOL_GOOGLE_CALL;
- return 1;
} else if(strstr(flow->host_server_name, "whispersystems.org") != NULL ||
strstr(flow->host_server_name, "signal.org") != NULL) {
*app_proto = NDPI_PROTOCOL_SIGNAL_VOIP;
- return 1;
} else if(strstr(flow->host_server_name, "facebook") != NULL) {
*app_proto = NDPI_PROTOCOL_FACEBOOK_VOIP;
- return 1;
} else if(strstr(flow->host_server_name, "stripcdn.com") != NULL) {
*app_proto = NDPI_PROTOCOL_ADULT_CONTENT;
- return 1;
} else if(strstr(flow->host_server_name, "telegram") != NULL) {
*app_proto = NDPI_PROTOCOL_TELEGRAM_VOIP;
- return 1;
}
} else
flow->host_server_name[0] = '\0';
@@ -540,7 +535,7 @@ int is_stun(struct ndpi_detection_module_struct *ndpi_struct,
case 0xFF03:
*app_proto = NDPI_PROTOCOL_GOOGLE_CALL;
- return 1;
+ break;
case 0x0013:
NDPI_LOG_DBG(ndpi_struct, "DATA attribute (%d/%d)\n",