diff options
| author | Toni Uhlig <matzeton@googlemail.com> | 2021-06-29 15:03:18 +0200 |
|---|---|---|
| committer | Toni Uhlig <matzeton@googlemail.com> | 2021-06-29 15:03:18 +0200 |
| commit | c84ccddd71247389e6d483e1e676542b4cee1622 (patch) | |
| tree | 9df7ff98cf27ba9e0bbac21790c0c3aff8ca14f3 | |
| parent | e5fd86393e3528f9ed76ca51c607e8ca27155fcd (diff) | |
Fixed off-by-one memory error for TLS-JA3.fix/tls-ja3-off-by-one
Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
| -rw-r--r-- | src/lib/protocols/tls.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/lib/protocols/tls.c b/src/lib/protocols/tls.c index 4f376a4ff..ed3caed5f 100644 --- a/src/lib/protocols/tls.c +++ b/src/lib/protocols/tls.c @@ -1849,7 +1849,11 @@ int processClientServerHello(struct ndpi_detection_module_struct *ndpi_struct, duplicate_found); #endif - ja3.client.signature_algorithms[i*2] = '\0'; + if (i == tot_signature_algorithms_len) { + ja3.client.signature_algorithms[i*2 - 1] = '\0'; + } else { + ja3.client.signature_algorithms[i*2] = '\0'; + } #ifdef DEBUG_TLS printf("Client TLS [SIGNATURE_ALGORITHMS: %s]\n", ja3.client.signature_algorithms); |