aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Nardi <12729895+IvanNardi@users.noreply.github.com>2022-02-09 11:46:39 +0100
committerGitHub <noreply@github.com>2022-02-09 11:46:39 +0100
commitf229068fd3844cd2fd458e5ae76c20ec059c8d3e (patch)
tree20933e257fa552530cd5688ef8b50e37d1139d6a
parenta6ff0dd0e3b14e3f7e396a1d5ea125cc2ae9b82f (diff)
Fix memory access in ndpi_strnstr() (#1438)
Found by oss-fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44482 It should be the same error reported (and only partially fixed) in 79968f32
Diffstat
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/ndpi_main.c b/src/lib/ndpi_main.c
index ee1be878b..9bee39db5 100644
--- a/src/lib/ndpi_main.c
+++ b/src/lib/ndpi_main.c
@@ -7141,9 +7141,9 @@ char *ndpi_strnstr(const char *s, const char *find, size_t slen) {
const char * ndpi_strncasestr(const char *str1, const char *str2, size_t len) {
size_t str1_len = strnlen(str1, len);
size_t str2_len = strlen(str2);
- size_t i;
+ int i; /* signed! */
- for(i = 0; i < (str1_len - str2_len + 1); i++){
+ for(i = 0; i < (int)(str1_len - str2_len + 1); i++){
if(str1[0] == '\0')
return NULL;
else if(strncasecmp(str1, str2, str2_len) == 0)
Powered by cgit, Themed by Ted Yin.