aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJarred Nicholls <jtn@ironnetcybersecurity.com>2015-06-24 20:34:13 -0400
committerJarred Nicholls <jtn@ironnetcybersecurity.com>2015-06-24 20:38:01 -0400
commit1d9d0b89abdb91abff97a56635ab9b43cea1c981 (patch)
tree121b2d2b0df96218d248d90c4090d1799bcb622c
parent9bb99ed01d9404072ff100c4d802c5fd525f4a15 (diff)
Account for the skipping of the DNS RR CLASS field by progressing the payload index forward by an extra 2 octets. Remove commented code.
-rw-r--r--src/lib/protocols/dns.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/lib/protocols/dns.c b/src/lib/protocols/dns.c
index 631514afd..ee1ffdf5f 100644
--- a/src/lib/protocols/dns.c
+++ b/src/lib/protocols/dns.c
@@ -170,7 +170,7 @@ void ndpi_search_dns(struct ndpi_detection_module_struct *ndpi_struct, struct nd
i += 4;
if(header.answer_rrs > 0) {
- u_int16_t rsp_type /*, rsp_class */;
+ u_int16_t rsp_type;
u_int16_t num;
for(num = 0; num < header.answer_rrs; num++) {
@@ -186,9 +186,9 @@ void ndpi_search_dns(struct ndpi_detection_module_struct *ndpi_struct, struct nd
i += data_len;
rsp_type = get16(&i, packet->payload);
- // rsp_class = get16(&i, packet->payload);
- i += 4;
+ // Skip past the CLASS (2 octets) and TTL (4 octets) fields.
+ i += 6;
data_len = get16(&i, packet->payload);
if((data_len <= 1) || (data_len > (packet->payload_packet_len-i))) {