From ffbb0f6a60a000e42f26fd1e08925de1f2ff90be Mon Sep 17 00:00:00 2001
From: Frode Aannevik <frode.aa@gmail.com>
Date: Tue, 15 Oct 2019 23:09:47 +0200
Subject: token: disallow multiple tokens with same name (#5820)

* api/v1: don't allow multiple tokens with same name

Fail with 422 Unprocessable Entity if the token name
already exist

ref: https://github.com/gogs/gogs/issues/5587

* Move new token error type to models/errors/token

* Remove "useless" ListAccessTokensByName function

* Add an i18n entry for token_name_exists
---
 routes/user/setting.go | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'routes/user')

diff --git a/routes/user/setting.go b/routes/user/setting.go
index 2391fb98..e9d8182d 100644
--- a/routes/user/setting.go
+++ b/routes/user/setting.go
@@ -607,7 +607,12 @@ func SettingsApplicationsPost(c *context.Context, f form.NewAccessToken) {
 		Name: f.Name,
 	}
 	if err := models.NewAccessToken(t); err != nil {
-		c.ServerError("NewAccessToken", err)
+		if errors.IsAccessTokenNameAlreadyExist(err) {
+			c.Flash.Error(c.Tr("settings.token_name_exists"))
+			c.SubURLRedirect("/user/settings/applications")
+		} else {
+			c.ServerError("NewAccessToken", err)
+		}
 		return
 	}
 
-- 
cgit v1.2.3