From 1453e91f419e52fc74e3ec51b47a080a27a33342 Mon Sep 17 00:00:00 2001 From: Unknwon Date: Wed, 19 Aug 2015 20:08:57 +0800 Subject: minor fix on API response --- routers/api/v1/repo.go | 18 ++++++------------ routers/api/v1/user.go | 5 +++-- 2 files changed, 9 insertions(+), 14 deletions(-) (limited to 'routers/api/v1') diff --git a/routers/api/v1/repo.go b/routers/api/v1/repo.go index c6dabfcb..3f539417 100644 --- a/routers/api/v1/repo.go +++ b/routers/api/v1/repo.go @@ -120,7 +120,7 @@ func createRepo(ctx *middleware.Context, owner *models.User, opt api.CreateRepoO return } - ctx.JSON(200, ToApiRepository(owner, repo, api.Permission{true, true, true})) + ctx.JSON(201, ToApiRepository(owner, repo, api.Permission{true, true, true})) } // POST /user/repos @@ -254,17 +254,11 @@ func ListMyRepos(ctx *middleware.Context) { i := numOwnRepos for repo, access := range accessibleRepos { - if err = repo.GetOwner(); err != nil { - ctx.JSON(500, &base.ApiJsonErr{"GetOwner: " + err.Error(), base.DOC_URL}) - return - } - - repos[i] = ToApiRepository(repo.Owner, repo, api.Permission{false, access >= models.ACCESS_MODE_WRITE, true}) - - // FIXME: cache result to reduce DB query? - if repo.Owner.IsOrganization() && repo.Owner.IsOwnedBy(ctx.User.Id) { - repos[i].Permissions.Admin = true - } + repos[i] = ToApiRepository(repo.Owner, repo, api.Permission{ + Admin: access >= models.ACCESS_MODE_ADMIN, + Push: access >= models.ACCESS_MODE_WRITE, + Pull: true, + }) i++ } diff --git a/routers/api/v1/user.go b/routers/api/v1/user.go index 60b6adcd..57bf68bb 100644 --- a/routers/api/v1/user.go +++ b/routers/api/v1/user.go @@ -12,7 +12,6 @@ import ( "github.com/gogits/gogs/models" "github.com/gogits/gogs/modules/base" "github.com/gogits/gogs/modules/middleware" - "github.com/gogits/gogs/modules/setting" ) // ToApiUser converts user to API format. @@ -20,7 +19,9 @@ func ToApiUser(u *models.User) *api.User { return &api.User{ ID: u.Id, UserName: u.Name, - AvatarUrl: string(setting.Protocol) + u.AvatarLink(), + FullName: u.FullName, + Email: u.Email, + AvatarUrl: u.AvatarLink(), } } -- cgit v1.2.3