From d96f2a71849ed312c3c69177f1cb7b4a174421da Mon Sep 17 00:00:00 2001 From: leonklingele Date: Wed, 21 Dec 2016 09:41:37 +0100 Subject: Fix random string generator (#3953) * Remove unused custom-alphabet feature of random string generator * Fix modulo-biased random string generator * Random string generator should return error if it fails to read random data via crypto/rand --- models/user_mail.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'models/user_mail.go') diff --git a/models/user_mail.go b/models/user_mail.go index 9a1804c9..b9b210f4 100644 --- a/models/user_mail.go +++ b/models/user_mail.go @@ -111,7 +111,9 @@ func (email *EmailAddress) Activate() error { if err != nil { return err } - user.Rands = GetUserSalt() + if user.Rands, err = GetUserSalt(); err != nil { + return err + } sess := x.NewSession() defer sessionRelease(sess) -- cgit v1.2.3