From c912494609470f10401594391c6f2763684cb624 Mon Sep 17 00:00:00 2001
From: Unknwon <u@gogs.io>
Date: Sat, 23 Jul 2016 15:59:19 +0800
Subject: #3076 detect invalid tag name git error

---
 models/release.go | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

(limited to 'models/release.go')

diff --git a/models/release.go b/models/release.go
index 026ab8ff..2355ef30 100644
--- a/models/release.go
+++ b/models/release.go
@@ -67,9 +67,12 @@ func createTag(gitRepo *git.Repository, rel *Release) error {
 				return fmt.Errorf("GetBranchCommit: %v", err)
 			}
 
-			// Trim '--' prefix to prevent command line argument vulnerability
+			// Trim '--' prefix to prevent command line argument vulnerability.
 			rel.TagName = strings.TrimPrefix(rel.TagName, "--")
 			if err = gitRepo.CreateTag(rel.TagName, commit.ID.String()); err != nil {
+				if strings.Contains(err.Error(), "is not a valid tag name") {
+					return ErrInvalidTagName{rel.TagName}
+				}
 				return err
 			}
 		} else {
-- 
cgit v1.2.3