From 0e6a6bf880f950dfc46545b4172bfa980dd6d505 Mon Sep 17 00:00:00 2001 From: Unknwon Date: Sun, 11 Jun 2017 03:06:36 -0400 Subject: Refactoring: remove sessionRelease() XORM supports automatic roll back in session Close() already. --- models/milestone.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'models/milestone.go') diff --git a/models/milestone.go b/models/milestone.go index 544ef826..72fe5f63 100644 --- a/models/milestone.go +++ b/models/milestone.go @@ -115,7 +115,7 @@ func (m *Milestone) CountIssues(isClosed, includePulls bool) int64 { // NewMilestone creates new milestone of repository. func NewMilestone(m *Milestone) (err error) { sess := x.NewSession() - defer sessionRelease(sess) + defer sess.Close() if err = sess.Begin(); err != nil { return err } @@ -211,7 +211,7 @@ func ChangeMilestoneStatus(m *Milestone, isClosed bool) (err error) { } sess := x.NewSession() - defer sessionRelease(sess) + defer sess.Close() if err = sess.Begin(); err != nil { return err } @@ -254,7 +254,7 @@ func changeMilestoneIssueStats(e *xorm.Session, issue *Issue) error { // for the milestone associated with the given issue. func ChangeMilestoneIssueStats(issue *Issue) (err error) { sess := x.NewSession() - defer sessionRelease(sess) + defer sess.Close() if err = sess.Begin(); err != nil { return err } @@ -378,7 +378,7 @@ func DeleteMilestoneOfRepoByID(repoID, id int64) error { } sess := x.NewSession() - defer sessionRelease(sess) + defer sess.Close() if err = sess.Begin(); err != nil { return err } -- cgit v1.2.3