From d96f2a71849ed312c3c69177f1cb7b4a174421da Mon Sep 17 00:00:00 2001 From: leonklingele Date: Wed, 21 Dec 2016 09:41:37 +0100 Subject: Fix random string generator (#3953) * Remove unused custom-alphabet feature of random string generator * Fix modulo-biased random string generator * Random string generator should return error if it fails to read random data via crypto/rand --- models/migrations/migrations.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'models/migrations/migrations.go') diff --git a/models/migrations/migrations.go b/models/migrations/migrations.go index edd07a66..e2b8bfb2 100644 --- a/models/migrations/migrations.go +++ b/models/migrations/migrations.go @@ -451,8 +451,12 @@ func generateOrgRandsAndSalt(x *xorm.Engine) (err error) { } for _, org := range orgs { - org.Rands = base.GetRandomString(10) - org.Salt = base.GetRandomString(10) + if org.Rands, err = base.GetRandomString(10); err != nil { + return err + } + if org.Salt, err = base.GetRandomString(10); err != nil { + return err + } if _, err = sess.Id(org.ID).Update(org); err != nil { return err } -- cgit v1.2.3