From b40b85e006d0e3858b423e36d437de73cd08d00a Mon Sep 17 00:00:00 2001 From: Guy Smoilov <611655+guysmoilov@users.noreply.github.com> Date: Sun, 3 Nov 2019 21:07:40 +0200 Subject: repo: delete local copies on owner name change (#5843) * Protect local repo copy deletion with repoWorkingPool, and delete the local copy on owner name change. * Update internal/db/user.go Co-Authored-By: Unknwon * Error format on local repo and wiki deletion --- internal/db/user.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'internal/db/user.go') diff --git a/internal/db/user.go b/internal/db/user.go index 3318a4be..003e2efd 100644 --- a/internal/db/user.go +++ b/internal/db/user.go @@ -667,13 +667,15 @@ func ChangeUserName(u *User, newUserName string) (err error) { return fmt.Errorf("ChangeUsernameInPullRequests: %v", err) } - // Delete all local copies of repository wiki that user owns. + // Delete all local copies of repositories and wikis the user owns. if err = x.Where("owner_id=?", u.ID).Iterate(new(Repository), func(idx int, bean interface{}) error { repo := bean.(*Repository) + deleteRepoLocalCopy(repo) + // TODO: By the same reasoning, shouldn't we also sync access to the local wiki path? RemoveAllWithNotice("Delete repository wiki local copy", repo.LocalWikiPath()) return nil }); err != nil { - return fmt.Errorf("Delete repository wiki local copy: %v", err) + return fmt.Errorf("delete repository and wiki local copy: %v", err) } // Rename or create user base directory -- cgit v1.2.3