From f2ec0d80a81902c20b3dc95908a1d5796148bda9 Mon Sep 17 00:00:00 2001 From: Unknwon Date: Tue, 4 Dec 2018 19:35:44 -0500 Subject: user/auth: flush and destroy session at logout (#5540) Reported by @cezar97. --- gogs.go | 2 +- routes/user/auth.go | 4 ++-- vendor/vendor.json | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gogs.go b/gogs.go index 97035133..350719e0 100644 --- a/gogs.go +++ b/gogs.go @@ -16,7 +16,7 @@ import ( "github.com/gogs/gogs/pkg/setting" ) -const APP_VER = "0.11.75.1203" +const APP_VER = "0.11.76.1204" func init() { setting.AppVer = APP_VER diff --git a/routes/user/auth.go b/routes/user/auth.go index 3140d9f9..d57eba65 100644 --- a/routes/user/auth.go +++ b/routes/user/auth.go @@ -281,8 +281,8 @@ func LoginTwoFactorRecoveryCodePost(c *context.Context) { } func SignOut(c *context.Context) { - c.Session.Delete("uid") - c.Session.Delete("uname") + c.Session.Flush() + c.Session.Destory(c.Context) c.SetCookie(setting.CookieUserName, "", -1, setting.AppSubURL) c.SetCookie(setting.CookieRememberName, "", -1, setting.AppSubURL) c.SetCookie(setting.CSRFCookieName, "", -1, setting.AppSubURL) diff --git a/vendor/vendor.json b/vendor/vendor.json index 2aa0798f..aef7bebd 100644 --- a/vendor/vendor.json +++ b/vendor/vendor.json @@ -135,16 +135,16 @@ "revisionTime": "2016-06-27T17:00:12Z" }, { - "checksumSHA1": "qLY+SEQlwlFlpUwT2ZyUv+UlsxA=", + "checksumSHA1": "/t1kyFHHcqE/fUrjgdw9X8PlrqQ=", "path": "github.com/go-macaron/session", - "revision": "068d408f9c54c7fa7fcc5e2bdd3241ab21280c9e", - "revisionTime": "2018-11-07T03:18:28Z" + "revision": "cdb0ddf74421e2bbc43443789c46540f5235a71a", + "revisionTime": "2018-12-05T00:27:18Z" }, { - "checksumSHA1": "jVW5CmzplA0UDjai0AFYJFVXAJk=", + "checksumSHA1": "AGaED15nGifQkpU2bpU9Kgd7O4A=", "path": "github.com/go-macaron/session/redis", - "revision": "068d408f9c54c7fa7fcc5e2bdd3241ab21280c9e", - "revisionTime": "2018-11-07T03:18:28Z" + "revision": "cdb0ddf74421e2bbc43443789c46540f5235a71a", + "revisionTime": "2018-12-05T00:27:18Z" }, { "checksumSHA1": "VMRkwnbl0mKWWvK/62CnIlv1oOg=", -- cgit v1.2.3