aboutsummaryrefslogtreecommitdiff
path: root/internal/db
diff options
context:
space:
mode:
Diffstat (limited to 'internal/db')
-rw-r--r--internal/db/repo_editor.go6
-rw-r--r--internal/db/repo_editor_test.go45
2 files changed, 33 insertions, 18 deletions
diff --git a/internal/db/repo_editor.go b/internal/db/repo_editor.go
index 9d4664be..98065d43 100644
--- a/internal/db/repo_editor.go
+++ b/internal/db/repo_editor.go
@@ -467,10 +467,12 @@ type UploadRepoFileOptions struct {
// path of the repository.
func isRepositoryGitPath(path string) bool {
return strings.HasSuffix(path, ".git") ||
- strings.Contains(path, ".git"+string(os.PathSeparator)) ||
+ strings.Contains(path, ".git/") ||
+ strings.Contains(path, `.git\`) ||
// Windows treats ".git." the same as ".git"
strings.HasSuffix(path, ".git.") ||
- strings.Contains(path, ".git."+string(os.PathSeparator))
+ strings.Contains(path, ".git./") ||
+ strings.Contains(path, `.git.\`)
}
func (repo *Repository) UploadRepoFiles(doer *User, opts UploadRepoFileOptions) error {
diff --git a/internal/db/repo_editor_test.go b/internal/db/repo_editor_test.go
index ea2bf7a9..6aeed011 100644
--- a/internal/db/repo_editor_test.go
+++ b/internal/db/repo_editor_test.go
@@ -5,7 +5,6 @@
package db
import (
- "path/filepath"
"testing"
"github.com/stretchr/testify/assert"
@@ -16,23 +15,37 @@ func Test_isRepositoryGitPath(t *testing.T) {
path string
wantVal bool
}{
- {path: filepath.Join(".", ".git"), wantVal: true},
- {path: filepath.Join(".", ".git", ""), wantVal: true},
- {path: filepath.Join(".", ".git", "hooks", "pre-commit"), wantVal: true},
- {path: filepath.Join(".git", "hooks"), wantVal: true},
- {path: filepath.Join("dir", ".git"), wantVal: true},
-
- {path: filepath.Join(".", ".git."), wantVal: true},
- {path: filepath.Join(".", ".git.", ""), wantVal: true},
- {path: filepath.Join(".", ".git.", "hooks", "pre-commit"), wantVal: true},
- {path: filepath.Join(".git.", "hooks"), wantVal: true},
- {path: filepath.Join("dir", ".git."), wantVal: true},
-
- {path: filepath.Join(".gitignore"), wantVal: false},
- {path: filepath.Join("dir", ".gitkeep"), wantVal: false},
+ {path: ".git", wantVal: true},
+ {path: "./.git", wantVal: true},
+ {path: ".git/hooks/pre-commit", wantVal: true},
+ {path: ".git/hooks", wantVal: true},
+ {path: "dir/.git", wantVal: true},
+
+ {path: ".gitignore", wantVal: false},
+ {path: "dir/.gitkeep", wantVal: false},
+
+ // Windows-specific
+ {path: `.git\`, wantVal: true},
+ {path: `.git\hooks\pre-commit`, wantVal: true},
+ {path: `.git\hooks`, wantVal: true},
+ {path: `dir\.git`, wantVal: true},
+
+ {path: `.\.git.`, wantVal: true},
+ {path: `.\.git.\`, wantVal: true},
+ {path: `.git.\hooks\pre-commit`, wantVal: true},
+ {path: `.git.\hooks`, wantVal: true},
+ {path: `dir\.git.`, wantVal: true},
+
+ {path: "./.git.", wantVal: true},
+ {path: "./.git./", wantVal: true},
+ {path: ".git./hooks/pre-commit", wantVal: true},
+ {path: ".git./hooks", wantVal: true},
+ {path: "dir/.git.", wantVal: true},
+
+ {path: `dir\.gitkeep`, wantVal: false},
}
for _, test := range tests {
- t.Run("", func(t *testing.T) {
+ t.Run(test.path, func(t *testing.T) {
assert.Equal(t, test.wantVal, isRepositoryGitPath(test.path))
})
}