diff options
| author | leonklingele <git@leonklingele.de> | 2016-12-21 09:41:37 +0100 |
|---|---|---|
| committer | 无闻 <u@gogs.io> | 2016-12-21 03:41:37 -0500 |
| commit | d96f2a71849ed312c3c69177f1cb7b4a174421da (patch) | |
| tree | 8d68aa9631801722ecaeab3d2089bb2a922794b6 /routers/user/setting.go | |
| parent | adcb1d7c651720d71efea238e011582b9e455c2d (diff) | |
Fix random string generator (#3953)
* Remove unused custom-alphabet feature of random string generator
* Fix modulo-biased random string generator
* Random string generator should return error if it fails to read random data via crypto/rand
Diffstat (limited to 'routers/user/setting.go')
| -rw-r--r-- | routers/user/setting.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/routers/user/setting.go b/routers/user/setting.go index 10e8fd02..35bff326 100644 --- a/routers/user/setting.go +++ b/routers/user/setting.go @@ -189,7 +189,11 @@ func SettingsPasswordPost(ctx *context.Context, form auth.ChangePasswordForm) { ctx.Flash.Error(ctx.Tr("form.password_not_match")) } else { ctx.User.Passwd = form.Password - ctx.User.Salt = models.GetUserSalt() + var err error + if ctx.User.Salt, err = models.GetUserSalt(); err != nil { + ctx.Handle(500, "UpdateUser", err) + return + } ctx.User.EncodePasswd() if err := models.UpdateUser(ctx.User); err != nil { ctx.Handle(500, "UpdateUser", err) |