webhook: overhaul route handlers (#6002)

* Overual route handlers and fixes #5366

* Merge routes for repo and org

* Inject OrgRepoContext

* DRY validateWebhook

* DRY c.HasError

* Add tests

* Update CHANGELOG

1 files changed, 108 insertions, 95 deletions

diff --git a/public/less/_form.less b/public/less/_form.less
index 8808485a..0151a924 100644
--- a/public/less/_form.less
+++ b/public/less/_form.less
@@ -1,50 +1,50 @@
 .form {
-	.help {
-		color: #999999;
-	  padding-top: .6em;
-	  padding-bottom: .6em;
-	  display: inline-block;
-	  word-break: break-word;
-	}
+  .help {
+    color: #999999;
+    padding-top: 0.6em;
+    padding-bottom: 0.6em;
+    display: inline-block;
+    word-break: break-word;
+  }
 }
 .ui.attached.header {
-	background: #f0f0f0;
-	.right {
-		margin-top: -5px;
-		.button {
-			padding: 8px 10px;
-			font-weight: normal;
-		}
-	}
+  background: #f0f0f0;
+  .right {
+    margin-top: -5px;
+    .button {
+      padding: 8px 10px;
+      font-weight: normal;
+    }
+  }
 }
 
 @create-page-form-input-padding: 250px !important;
 #create-page-form {
-	form {
-		margin: auto;
-		width: 800px!important;
-		.ui.message {
-			text-align: center;
-		}
-		.header {
-			padding-left: @create-page-form-input-padding+30px;
-		}
-		.inline.field > label {
-			text-align: right;
-			width: @create-page-form-input-padding;
-			word-wrap: break-word;
-		}
-		.help {
-			margin-left: @create-page-form-input-padding+15px;
-		}
-		.optional .title {
-			margin-left: @create-page-form-input-padding;
-		}
-		input,
-		textarea {
-			width: 50% !important;
-		}
-	}
+  form {
+    margin: auto;
+    width: 800px !important;
+    .ui.message {
+      text-align: center;
+    }
+    .header {
+      padding-left: @create-page-form-input-padding+30px;
+    }
+    .inline.field > label {
+      text-align: right;
+      width: @create-page-form-input-padding;
+      word-wrap: break-word;
+    }
+    .help {
+      margin-left: @create-page-form-input-padding+15px;
+    }
+    .optional .title {
+      margin-left: @create-page-form-input-padding;
+    }
+    input,
+    textarea {
+      width: 50% !important;
+    }
+  }
 }
 
 .user.activate,
@@ -52,72 +52,85 @@
 .user.reset.password,
 .user.signin,
 .user.signup {
-	@input-padding: 200px !important;
-	#create-page-form;
-	form {
-		width: 700px !important;
-		.header {
-			padding-left: @input-padding+30px;
-		}
-		.inline.field > label {
-			width: @input-padding;
-		}
-	}
+  @input-padding: 200px !important;
+  #create-page-form;
+  form {
+    width: 700px !important;
+    .header {
+      padding-left: @input-padding+30px;
+    }
+    .inline.field > label {
+      width: @input-padding;
+    }
+  }
 }
 
 .user.signin.two-factor {
-	form {
-		width: 300px !important;
-		.header {
-			padding-left: inherit !important;
-		}
-	}
+  form {
+    width: 300px !important;
+    .header {
+      padding-left: inherit !important;
+    }
+  }
 }
 
 .repository {
-	&.new.repo,
-	&.new.migrate,
-	&.new.fork {
-		#create-page-form;
-		form {
-			.dropdown {
-				.dropdown.icon {
-					margin-top: -7px!important;
-				}
-				.text {
-					margin-right: 0!important;
-					i {
-						margin-right: 0!important;
-					}
-				}
-			}
-		}
-	}
+  &.new.repo,
+  &.new.migrate,
+  &.new.fork {
+    #create-page-form;
+    form {
+      .dropdown {
+        .dropdown.icon {
+          margin-top: -7px !important;
+        }
+        .text {
+          margin-right: 0 !important;
+          i {
+            margin-right: 0 !important;
+          }
+        }
+      }
+    }
+  }
 
-	&.new.repo {
-		.ui.form {
-			.selection.dropdown:not(.owner) {
-				width: 50%!important;
-			}
-			#auto-init {
-				margin-left: @create-page-form-input-padding+15px;
-			}
-		}
-	}
+  &.new.repo {
+    .ui.form {
+      .selection.dropdown:not(.owner) {
+        width: 50% !important;
+      }
+      #auto-init {
+        margin-left: @create-page-form-input-padding+15px;
+      }
+    }
+  }
 }
 
 .new.webhook {
-	form {
-		.help {
-			margin-left: 25px;
-		}
-	}
+  form {
+    .text.desc {
+      margin-top: 5px;
+    }
+    .help {
+      margin-left: 25px;
+    }
+    .events {
+      .column {
+        padding-bottom: 0;
+      }
+      .help {
+        font-size: 13px;
+        margin-left: 26px;
+        padding-top: 0;
+      }
+    }
+  }
 }
 
 .new.webhook {
-	.events.fields {
-		.column {
-			padding-left: 40px;
-		}
-	}
+  .events.fields {
+    .column {
+      padding-left: 40px;
+    }
+  }
 }