diff options
| author | leonklingele <git@leonklingele.de> | 2016-12-21 09:41:37 +0100 |
|---|---|---|
| committer | 无闻 <u@gogs.io> | 2016-12-21 03:41:37 -0500 |
| commit | d96f2a71849ed312c3c69177f1cb7b4a174421da (patch) | |
| tree | 8d68aa9631801722ecaeab3d2089bb2a922794b6 /models/migrations | |
| parent | adcb1d7c651720d71efea238e011582b9e455c2d (diff) | |
Fix random string generator (#3953)
* Remove unused custom-alphabet feature of random string generator
* Fix modulo-biased random string generator
* Random string generator should return error if it fails to read random data via crypto/rand
Diffstat (limited to 'models/migrations')
| -rw-r--r-- | models/migrations/migrations.go | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/models/migrations/migrations.go b/models/migrations/migrations.go index edd07a66..e2b8bfb2 100644 --- a/models/migrations/migrations.go +++ b/models/migrations/migrations.go @@ -451,8 +451,12 @@ func generateOrgRandsAndSalt(x *xorm.Engine) (err error) { } for _, org := range orgs { - org.Rands = base.GetRandomString(10) - org.Salt = base.GetRandomString(10) + if org.Rands, err = base.GetRandomString(10); err != nil { + return err + } + if org.Salt, err = base.GetRandomString(10); err != nil { + return err + } if _, err = sess.Id(org.ID).Update(org); err != nil { return err } |