Skip deletion for temporary data when not exist on Windows (#4069)

1 files changed, 2 insertions, 1 deletions

diff --git a/models/admin.go b/models/admin.go
index 68731a24..c9a13eb5 100644
--- a/models/admin.go
+++ b/models/admin.go
@@ -77,7 +77,8 @@ func RemoveAllWithNotice(title, path string) {
 	// workaround for Go not being able to remove read-only files/folders: https://github.com/golang/go/issues/9606
 	// this bug should be fixed on Go 1.7, so the workaround should be removed when Gogs don't support Go 1.6 anymore:
 	// https://github.com/golang/go/commit/2ffb3e5d905b5622204d199128dec06cefd57790
-	if setting.IsWindows {
+	// Note: Windows complains when delete target does not exist, therefore we can skip deletion in such cases.
+	if setting.IsWindows && com.IsExist(path) {
 		// converting "/" to "\" in path on Windows
 		path = strings.Replace(path, "/", "\\", -1)
 		err = exec.Command("cmd", "/C", "rmdir", "/S", "/Q", path).Run()