| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
| |
Change-Id: I270148b9ae9afde304144a57c43faae872a66bfa
Reviewed-on: https://go-review.googlesource.com/13819
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
| |
Change-Id: Iba64aa52334522c6ece1cfa4a4c13566dd0a1324
Reviewed-on: https://go-review.googlesource.com/13665
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
| |
Change-Id: I05cb4a4d4b0f0436181ee5d1ec59c10c757edf8d
Reviewed-on: https://go-review.googlesource.com/12786
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
| |
Change-Id: Ib39578e45cf1905f5d16e2a1270b8c4889dcba34
Reviewed-on: https://go-review.googlesource.com/12815
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
|
|
|
|
| |
Gopher has no gender, but masculine pronouns are used throught
the article. Small tweaks allow us to make the gopher gender-neutral
in the scope of this blog post.
Change-Id: I18c326c01ecf9fc32a62ef1f54ad5a70265ff832
Reviewed-on: https://go-review.googlesource.com/12448
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
|
|
| |
TBR=rsc
Change-Id: I94eeb1ca0379f8a57709c5bf9198abff25a7226f
Reviewed-on: https://go-review.googlesource.com/11957
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
| |
Change-Id: Icd4157f0a818bf5c93885b3f9c508a03c834a711
Reviewed-on: https://go-review.googlesource.com/11984
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
| |
Change-Id: I1a1026473525ffb68ff0af07576cccd0ccd79ed4
Reviewed-on: https://go-review.googlesource.com/11983
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
| |
Change-Id: I10386c4cf1ccde39754a6b6503d98109230e4d94
Reviewed-on: https://go-review.googlesource.com/11910
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
| |
Change-Id: Ibdc8e184773161b8c80144eaf2ef8b554b4861bc
Reviewed-on: https://go-review.googlesource.com/10778
Reviewed-by: Robert Griesemer <gri@golang.org>
|
|
|
|
|
|
| |
Change-Id: I7984f82a53a0c4ed087a0d439616d23ef1871055
Reviewed-on: https://go-review.googlesource.com/11851
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
| |
Change-Id: I743daf846f798b3c69882279fa95847af824dce0
Reviewed-on: https://go-review.googlesource.com/10136
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
|
|
| |
Fixes golang/go#9471
Change-Id: I19b7b5bf62d6eee76e65730de535141638cf66e4
Reviewed-on: https://go-review.googlesource.com/9666
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
|
|
| |
The outyet package already contains a `Dockerfile`.
Change-Id: I85ac3db2d80966db02d4d1ce9d2bcf2721f06016
Reviewed-on: https://go-review.googlesource.com/7460
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
|
|
|
|
| |
The Go protocol buffer package is now on github.
Also mention that unsafe is no longer used.
Change-Id: Ib81ecfc9b347924c9569a3f454cb147ace3f3a7f
Reviewed-on: https://go-review.googlesource.com/6351
Reviewed-by: David Symonds <dsymonds@golang.org>
|
|
|
|
|
|
|
|
|
|
| |
I received a question about whether package functions named "New" were required
(they're not), so I'm adding examples of functions named "WithX" and "FromY" to
show other useful forms.
Change-Id: Iff3ddec3dca3344762f09ba52de9cd515a4bc863
Reviewed-on: https://go-review.googlesource.com/5572
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
| |
Change-Id: I032f1d9163048e0d4b80c8e0a2330f772bb77e19
Reviewed-on: https://go-review.googlesource.com/3968
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
| |
Change-Id: Iddb15b375e2e11207105d3373b4c8f77e6dd7633
Reviewed-on: https://go-review.googlesource.com/3843
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
|
|
| |
bufio.NewWriter already returns a pointer.
Change-Id: I6348b11c2dcb4a371aefb4a151c68fbb6b4bc616
Reviewed-on: https://go-review.googlesource.com/3268
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
| |
Change-Id: Ic440bb4bff6a1efd63820a2981931913cb5f1f84
Reviewed-on: https://go-review.googlesource.com/2710
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
|
|
|
| |
I won't submit it this time. Sorry.
Change-Id: I3a63985bf6b12a22d0371f8fdf5c0fcd2a01ff8b
Reviewed-on: https://go-review.googlesource.com/2539
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
| |
Also add a newline at the end of the file.
Change-Id: I4063c58d5f5ac8043946f57e6ab0a0bc8f36452b
Reviewed-on: https://go-review.googlesource.com/2631
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
|
|
|
|
|
| |
Change-Id: Ib8152a597660db9e3b869bb63967f6730baed468
Reviewed-on: https://go-review.googlesource.com/2601
Reviewed-by: Sameer Ajmani <sameer@golang.org>
|
|
|
|
|
|
|
|
|
| |
The GothamGo post needs to go out first.
If we push with this in the repo, it'll appear early.
Change-Id: Ifb4093f948e10ffdde1ec278f66195324b398f2d
Reviewed-on: https://go-review.googlesource.com/2538
Reviewed-by: Rob Pike <r@golang.org>
|
|
|
|
|
|
| |
Change-Id: I1c47009cbd0f858a6c62c90d4b8d8eeea2e469b2
Reviewed-on: https://go-review.googlesource.com/2537
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
|
| |
Change-Id: I69735b26c560999d26fdbd40bbba8521ad2650b8
Reviewed-on: https://go-review.googlesource.com/2561
Reviewed-by: Sameer Ajmani <sameer@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
| |
Change-Id: I6f93afe62baaddf9a09db433f29f14268e4e68ff
Reviewed-on: https://go-review.googlesource.com/2451
Reviewed-by: Sameer Ajmani <sameer@golang.org>
|
|
|
|
|
|
|
|
|
| |
Note to self: never hand-edit generated code.
This is the actual output from stringer.
Change-Id: I3900b790d2019afa5dc4ed55391d50cd4f772525
Reviewed-on: https://go-review.googlesource.com/1993
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
|
|
|
|
| |
During code review for this post, dsymonds noticed a way to simplify
the generated code. That simplification is now checked in, so bring the
post up to date.
Change-Id: If29587332c8cc210ecac4843e9dd45dfa01118f7
Reviewed-on: https://go-review.googlesource.com/2020
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
| |
Change-Id: Id9a9885ceb0bde6db65d3cdb2cb6964dab4ef8ab
Reviewed-on: https://go-review.googlesource.com/1931
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
| |
Change-Id: I53b93b5d94712128b78d1c0bc76eaa041b1532d8
Reviewed-on: https://go-review.googlesource.com/1342
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
|
|
|
|
|
|
| |
LGTM=dave, adg
R=adg, dave
CC=golang-codereviews
https://golang.org/cl/170510043
|
|
|
|
|
|
|
| |
TBR=r
R=r
CC=golang-codereviews
https://golang.org/cl/172240043
|
|
|
|
|
|
|
| |
TBR=r
R=r, reneefrench
CC=golang-codereviews
https://golang.org/cl/171460043
|
|
|
|
|
|
|
| |
TBR=adg
R=adg, campoy
CC=golang-codereviews
https://golang.org/cl/171400043
|
|
|
|
|
|
|
| |
LGTM=dsymonds
R=r, dsymonds
CC=golang-codereviews
https://golang.org/cl/171370043
|
|
|
|
|
|
|
| |
TBR=rsc
R=rsc, r
CC=golang-codereviews
https://golang.org/cl/170250043
|
|
|
|
|
|
|
| |
LGTM=adg
R=adg, campoy
CC=golang-codereviews
https://golang.org/cl/154920043
|
|
|
|
|
|
|
|
|
| |
The listed image suffers from the "shellshock" bash bug.
LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://golang.org/cl/150240043
|
|
|
|
|
|
|
| |
LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://golang.org/cl/145460043
|
|
|
|
|
|
|
| |
LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/148190043
|
|
|
|
|
|
|
|
|
| |
Fixes golang/go#8692.
LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/141420043
|
|
|
|
|
|
|
| |
LGTM=adg
R=adg, r
CC=golang-codereviews
https://golang.org/cl/133910043
|
|
|
|
|
|
|
|
|
| |
Otherwise the prose around this snippet is confusing.
LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/130550043
|
|
|
|
|
|
|
|
|
| |
All inconsequential.
LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/130540043
|
|
|
|
|
|
|
| |
LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/129630043
|
|
|
|
|
|
|
| |
LGTM=gri, adg, rsc
R=gri, adg, rsc
CC=golang-codereviews
https://golang.org/cl/125540043
|
|
|
|
|
|
|
| |
LGTM=campoy
R=golang-codereviews, gobot, campoy
CC=golang-codereviews
https://golang.org/cl/128490044
|
|
|
|
|
|
|
| |
LGTM=crawshaw
R=r, adg, crawshaw
CC=golang-codereviews
https://golang.org/cl/130330043
|
|
|
|
|
|
|
| |
LGTM=adg
R=adg, campoy
CC=golang-codereviews
https://golang.org/cl/127570043
|